fix(transactions): Defer dynamic sampling until metrics config is valid#6246
Merged
Conversation
jjbayer
commented
Jul 17, 2026
jjbayer
marked this pull request as ready for review
July 17, 2026 11:51
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Dav1dde
force-pushed
the
fix/ds-no-metrics
branch
2 times, most recently
from
July 24, 2026 07:29
c672f7a to
4537d8e
Compare
Dav1dde
force-pushed
the
fix/ds-no-metrics
branch
from
July 24, 2026 07:29
4537d8e to
622557e
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Dav1dde
enabled auto-merge
July 24, 2026 07:33
Dav1dde
force-pushed
the
fix/ds-no-metrics
branch
from
July 24, 2026 07:38
5dd2140 to
bfda6e4
Compare
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
loewenheim
approved these changes
Jul 24, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 24, 2026
Dav1dde
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If metrics extraction config is invalid, delegate dynamic sampling to the next relay. This prevents dropping transactions for which no metrics were extracted yet.
Fixes RELAY-268